Spree Commerce

Try It Now

Github Pull Requests Now Welcome

Posted on October 01, 2010 by Sean Schofield

A few weeks ago, the great folks at Github announced a drastically improved version of "pull requests." Up until this point we’ve been discouraging Spree users from sending us pull requests (even going as far as to warn users that "Github pull requests will be ignored.") We’re pleased to announce that this will no longer the case. In fact, Github pull requests will likely be encouraged going forward.

The Github team has also been kind enough to write up some great documentation on working with pull requests. Contributions should still be performed on topic branches in your personal forks – just issue your pull requests from there. We’re also asking that you continue to log important issues for non-trivial patches in our lighthouse repository. You can just link the pull request in the ticket (and link the ticket in the pull request.)

The Rails core team has already embraced accepting contributions via pull request – let’s see how this works for our project!